Move stray comment #897
Merged
Move stray comment #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamchainz seems that |
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Move comment
|
I moved the comment to the definition file, where I think it makes more sense, as an alternative solution. Hopefully this doesn't anger the auto-formatters. |
|
Thanks, this makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that this comment was moved to a somewhat random position after automated code cleanup, moved it back to where it was before.
See:
c171a32#diff-db31a113ed29f9d863809faac07a22adef130103b150b1305b53756baa398d6f